[PATCH] D151863: [x86][MC] Fix movdir64b addressing

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 5 21:35:09 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/X86/movdir64b-inline-asm-x86_64.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+movdir64b | FileCheck %s --check-prefix=X64
----------------
I think we should reuse an existing `*-inline-asm-*` test file.

See https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-at-the-wrong-layer "I don't know an existing test can be enhanced"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151863/new/

https://reviews.llvm.org/D151863



More information about the cfe-commits mailing list