[PATCH] D152071: [3/11][Clang][RISCV] Expand all variants for unit stride segment load

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/include/clang/Basic/riscv_vector.td:1533
+
+      if (NoPassthru) // Push poison into passthru
+        Operands.append(NF, llvm::PoisonValue::get(ElementVectorType));
----------------
`if` should use curly braces if the `else` uses curly braces.


================
Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:895
+  case 2:
+    return VectorTypeModifier::Tuple2;
+  case 3:
----------------
Can we guarantee Tuple2-8 are contiguous? Then we can do `return (NF - 2) + VectorTypeModifier::Tuple2`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152071/new/

https://reviews.llvm.org/D152071