[PATCH] D152169: [clang][analyzer] Add report of NULL stream to StreamChecker.

[Balázs Benics via Phabricator via cfe-commits]

steakhal added inline comments.


================
Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:553
   HelpText<"Check stream handling functions">,
+  WeakDependencies<[NonNullParamChecker]>,
   Documentation<HasDocumentation>;
----------------
balazske wrote:
> steakhal wrote:
> > What's the purpose of this hunk?
> The intent was that `NonNullParamChecker` should find a null pointer problem before `StreamChecker` and have a fixed priority of the warnings. But NonNullParamChecker probably does not apply to the stream functions because there are no nonnull attributes (this may be possible?) and no references. No tests fail if this line is removed.
Okay, I see. Choose as you want. I don't mind.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152169/new/

https://reviews.llvm.org/D152169