[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

Viktoriia Bakalova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 5 01:47:01 PDT 2023


VitaNuo added a comment.

Thanks for the comments!



================
Comment at: clang-tools-extra/clangd/Hover.cpp:1225
 
-  HI.Provider = spellHeader(AST, SM.getFileEntryForID(SM.getMainFileID()), H);
+  HI.Provider = include_cleaner::spellHeader(
+      {H, AST.getPreprocessor().getHeaderSearchInfo(),
----------------
hokein wrote:
> we probably need to add a `IncludeSpeller.h` #include insertion for this file, and probably for `clangd/IncludeCleaner.cpp` as well
Yeah also to the `IncludeCleanerCheck.cpp` now that I've rebased to main.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150185/new/

https://reviews.llvm.org/D150185



More information about the cfe-commits mailing list