[PATCH] D152126: [WebAssembly] Add tests ensuring rotates persist

Paulo Matos via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 5 01:16:14 PDT 2023


pmatos created this revision.
pmatos added reviewers: dschuff, tlively.
Herald added subscribers: asb, wingo, sunfish, jgravelle-google, sbc100.
Herald added a project: All.
pmatos requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, aheejin.
Herald added projects: clang, LLVM.

Due to the nature of WebAssembly, it's always better to keep
rotates instead of trying to optimize it. Commit 9485d983 <https://reviews.llvm.org/rG9485d983ac0c56d412c958b40f4e150a3c30ca7c>
disabled the generation of fsh for rotates, however these
tests ensure that future changes don't change the behaviour for
the Wasm backend that tends to have different optimization
requirements than other architectures. Also see:
https://github.com/llvm/llvm-project/issues/62703


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152126

Files:
  clang/test/CodeGen/WebAssembly/wasm-rotate.c
  llvm/test/CodeGen/WebAssembly/rotate-i3264.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152126.528306.patch
Type: text/x-patch
Size: 4929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230605/0e0d16c5/attachment.bin>


More information about the cfe-commits mailing list