[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

Mon Jun 5 01:05:56 PDT 2023

MyDeveloperDay added inline comments.

================
Comment at: clang/docs/ClangFormatStyleOptions.rst:790
+
+**AlignConsecutiveShortCaseLabels** (``AlignConsecutiveStyle``) :versionbadge:`clang-format 17` :ref:`¶ <AlignConsecutiveShortCaseLabels>`
+  Style of aligning consecutive short case labels.
----------------
HazardyKnusperkeks wrote:
> MyDeveloperDay wrote:
> > galenelias wrote:
> > > MyDeveloperDay wrote:
> > > > Did you generate this by hand or run the dump_format_style.py function? Format.h and the rst look out of sync
> > > This was generated from dump_format_style.py.  What looks out of sync?  My guess is the confusing thing is all the styles which use `AlignConsecutiveStyle` get the same documentation pasted for them which specifically references `AlignConsecutiveMacros` and makes it look like it's for the wrong option.
> > that doesn't feel right to me.. not saying its not dump_format_style.py but it shouldn't do that in my view
> What shouldn't it be doing?
> The struct is used for multiple options and the documentation is that ways since we have the struct.
I understand why its there, I just don't like that the text is repeated and doesn't really reference the case statements, (it could be confusing).

for example what would `PadOperators` mean in this case

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151761/new/

https://reviews.llvm.org/D151761