[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

Mon Jun 5 00:43:57 PDT 2023

hokein added a comment.

In D148793#4393386 <https://reviews.llvm.org/D148793#4393386>, @mstorsjo wrote:

> In D148793#4393385 <https://reviews.llvm.org/D148793#4393385>, @mgorny wrote:
>
>> My educated guess would be that `clangIncludeCleaner` is being linked via `clang_target_link_libraries` while it's not part of `libclang-cpp`, so it should go into regular `target_link_libraries`.
>
> Yes, that does seem to do the trick. LGTM from my PoV if you can push such a fix, otherwise I can try to do it in a little while...

Looks like it is fixed in https://github.com/llvm/llvm-project/commit/ac0ea7555ee4ae872bcd153e04513ba0b88b8985, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148793/new/

https://reviews.llvm.org/D148793