[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 5 00:14:48 PDT 2023


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

thanks, looks great.



================
Comment at: clang-tools-extra/clangd/SourceCode.h:76
+/// Get the last Position on a given line.
+llvm::Expected<Position> endOfLine(llvm::StringRef Code, int Line);
+
----------------
nit: no need to expose this API, it is only used in SemanticHighlighting.cpp.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151190/new/

https://reviews.llvm.org/D151190



More information about the cfe-commits mailing list