[clang-tools-extra] ac0ea75 - [clang-tools-extra] Fix linking when built with CLANG_LINK_CLANG_DYLIB=ON

Martin Storsjö via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 3 13:25:57 PDT 2023


Author: Martin Storsjö
Date: 2023-06-03T23:25:33+03:00
New Revision: ac0ea7555ee4ae872bcd153e04513ba0b88b8985

URL: https://github.com/llvm/llvm-project/commit/ac0ea7555ee4ae872bcd153e04513ba0b88b8985
DIFF: https://github.com/llvm/llvm-project/commit/ac0ea7555ee4ae872bcd153e04513ba0b88b8985.diff

LOG: [clang-tools-extra] Fix linking when built with CLANG_LINK_CLANG_DYLIB=ON

clangIncludeCleaner isn't part of libclang-cpp, so link it with
target_link_libraries instead of clang_target_link_libraries.

This fixes a regression from
c28506ba4b6961950849f8fdecd0cf7e503a14f9.

Fix suggested by Michal Gorny.

Added: 
    

Modified: 
    clang-tools-extra/clang-tidy/misc/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt
index fde72f6b25a54..a37f7b29ec999 100644
--- a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt
+++ b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt
@@ -56,10 +56,13 @@ clang_target_link_libraries(clangTidyMiscModule
   clangASTMatchers
   clangBasic
   clangFormat
-  clangIncludeCleaner
   clangLex
   clangSerialization
   clangTooling
   clangToolingInclusions
   clangToolingInclusionsStdlib
   )
+target_link_libraries(clangTidyMiscModule
+  PRIVATE
+  clangIncludeCleaner
+  )


        


More information about the cfe-commits mailing list