[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 3 12:25:39 PDT 2023


mstorsjo added a comment.

In D148793#4393385 <https://reviews.llvm.org/D148793#4393385>, @mgorny wrote:

> My educated guess would be that `clangIncludeCleaner` is being linked via `clang_target_link_libraries` while it's not part of `libclang-cpp`, so it should go into regular `target_link_libraries`.

Yes, that does seem to do the trick. LGTM from my PoV if you can push such a fix, otherwise I can try to do it in a little while...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148793/new/

https://reviews.llvm.org/D148793



More information about the cfe-commits mailing list