[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

Christopher Di Bella via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 2 14:27:02 PDT 2023


cjdb added inline comments.


================
Comment at: clang/lib/Sema/SemaExprCXX.cpp:5620
 
+  if (Kind == clang::TT_TypePackIndex)
+    return EvaluateIntegralTypeTrait(*this, Kind, KWLoc, Args, RParenLoc,
----------------
erichkeane wrote:
> I realize this is the 1st, but this seems like it is going to be a maintenance pain.  Can you at least split this into a static-function of `IsIntegralTypeTrait` that we can use later with table-gen if this gets out of hand?
Done, but in D152034. It's a change that should happen independently of this one IMO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151952/new/

https://reviews.llvm.org/D151952



More information about the cfe-commits mailing list