[PATCH] D148490: [AIX] use system assembler for assembly files

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/test/Driver/target-as.s:1
 // Make sure the -march is passed down to cc1as.
 // RUN: %clang -target i386-unknown-freebsd -### -c -integrated-as %s \
----------------
shchenz wrote:
> MaskRay wrote:
> > shchenz wrote:
> > > MaskRay wrote:
> > > > aix-as.c will be more appropriate.
> > > Do you mean we change this file to `aix-as.s` or we change back to previous version? The file `target-as.s` can not be renamed to `aix-as.s`, it also contains tests for i386, see the first run line.
> > You can add the new tests to the existing `aix-as.s`. The behavior is about assemblers on AIX. `aix-as.s` seems more appropriate than `target-as.s`.
> hmm, we want to use assembly file for test. There is aix-as.c but no aix-as.s.
You can use `-x assembler`. It's fairly common to use `-x c++ xxx.c` to test C++ with a C file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148490/new/

https://reviews.llvm.org/D148490