[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

In D149573#4391083 <https://reviews.llvm.org/D149573#4391083>, @codemzs wrote:

> In D149573#4391013 <https://reviews.llvm.org/D149573#4391013>, @erichkeane wrote:
>
>> In D149573#4390895 <https://reviews.llvm.org/D149573#4390895>, @codemzs wrote:
>>
>>> In D149573#4390863 <https://reviews.llvm.org/D149573#4390863>, @stuij wrote:
>>>
>>>> This is going to be a very unhelpful comment. After looking through the changes, I don't have any comments to make, but I also don't feel comfortable to accept this revision as I don't feel to know enough about the front-end.
>>>
>>> @stuij, I sincerely appreciate you taking the time to review the changes. Your hesitation due to unfamiliarity with the front-end elements is completely understandable, and I respect your candid feedback.
>>>
>>> @erichkeane, given your extensive contributions to the core `Sema`* files, I believe your expertise and experience would be particularly valuable in reviewing the changes I've made. I recall your initial informal approval for the change, and since then, I've further refined it after incorporating the outcomes of D150913 <https://reviews.llvm.org/D150913>. I'd be most appreciative if you could please review this revision once again.
>>>
>>> My intention is to ensure this revision aligns with our shared vision for LLVM/Clang, and your reviews will greatly contribute to this goal. If there are any other changes or improvements required for the successful landing of this revision, please feel free to let me know.
>>
>> I'll put you on my list to re-review for early next week, though Aaron probably needs to do a look through this as well.
>
> Thank you, @erichkeane that would be great, are you referring to @aaron.ballman ?

Yes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149573/new/

https://reviews.llvm.org/D149573