[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 2 06:31:32 PDT 2023


erichkeane added a comment.

1- This needs a release note.
2- I want others to comment on the name.  I like its verbosity in that it'll discourage people from using it without knowing what it means, but I want to hear Aaron/others' opinion as well.
3- Trailing WS thing, I see you did a cleanup patch, so just make sure this gets commited after that.



================
Comment at: clang/include/clang/Basic/AttrDocs.td:541
   let Content = [{
-If a statement is marked ``nomerge`` and contains call expressions, those call
-expressions inside the statement will not be merged during optimization. This 
+If a statement is marked ``nomerge`` and contains call expressions, those call 
+expressions inside the statement will not be merged during optimization. This
----------------
Trailing WS change, please don't do in this commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151625/new/

https://reviews.llvm.org/D151625



More information about the cfe-commits mailing list