[PATCH] D151863: [x86][MC] Fix movdir64b addressing

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 1 18:43:35 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:386
       return false;
+    if (getMemDisp()->getKind() == llvm::MCExpr::SymbolRef)
+      return true;
----------------
Wouldn't this allow "symbol + %eax" to pick the 64-bit instruction which is what the original change was trying to avoid?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151863/new/

https://reviews.llvm.org/D151863



More information about the cfe-commits mailing list