[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index
Christopher Di Bella via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 1 18:14:48 PDT 2023
cjdb added inline comments.
================
Comment at: clang/include/clang/AST/Stmt.h:796-802
+ /// If this expression is not value-dependent, this stores the value.
+ unsigned Value : 8;
/// The number of arguments to this type trait. According to [implimits]
/// 8 bits would be enough, but we require (and test for) at least 16 bits
/// to mirror FunctionType.
+ unsigned NumArgs : 16;
----------------
These numbers feel very low for how this modification is using them. Perhaps they should both be bumped to 32?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151952/new/
https://reviews.llvm.org/D151952
More information about the cfe-commits
mailing list