[PATCH] D151876: [NVPTX] Signed char and (unsigned)long overloads of ldg and ldu
Artem Belevich via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 1 14:31:51 PDT 2023
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
I'd change the patch title:
- `[NVPTX]` -> `[cuda, NVPTX]` as these are clang changes, not NVPTX back-end.
- `overloads ` -> `builtins`
================
Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:862
BUILTIN(__nvvm_ldg_c, "ccC*", "")
+BUILTIN(__nvvm_ldg_sc, "ScScC*", "")
BUILTIN(__nvvm_ldg_s, "ssC*", "")
----------------
One thing that bugs me is that ldg should technically be a `TARGET_BUILTIN(..., AND(PTX31,SM_32))`.
Oh, well, that train is gone now that pre-sm3x GPUs are no longer supported by NVIDIA anyways.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151876/new/
https://reviews.llvm.org/D151876
More information about the cfe-commits
mailing list