[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

Jessica Clarke via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 1 12:06:24 PDT 2023


jrtc27 added a comment.

In D149867#4387189 <https://reviews.llvm.org/D149867#4387189>, @glaubitz wrote:

> In D149867#4386271 <https://reviews.llvm.org/D149867#4386271>, @jrtc27 wrote:
>
>> I disagree. Being experimental doesn't mean you should do the wrong thing. Reusing stdcall in the frontend is ugly, pollutes non-m68k code paths (doing your own thing _avoids_ that and makes the experimental backend get out of the way, even) and introduces a bug where you can write garbage code and have it compile rather than be rejected like it should be.
>
> Maybe we can get the TLS stuff merged first before dealing with this more complex change?

They're totally independent, so nothing's blocking that being merged. Plus this isn't a complex change to make, just a bunch of copy pasta.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149867/new/

https://reviews.llvm.org/D149867



More information about the cfe-commits mailing list