[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang
Louis Dionne via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 1 11:35:53 PDT 2023
ldionne added inline comments.
================
Comment at: clang/test/Driver/darwin-header-search-libcxx.cpp:95
// Make sure that using -nostdinc, -nostdinc++ or -nostdlib will drop both the toolchain
// C++ include path and the sysroot one.
----------------
================
Comment at: clang/test/Driver/darwin-header-search-libcxx.cpp:105
// RUN: -nostdinc \
// RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_usr \
// RUN: -DTOOLCHAIN=%S/Inputs/basic_darwin_toolchain \
----------------
================
Comment at: clang/test/Driver/darwin-header-search-libcxx.cpp:133
// RUN: -nostdlibinc \
// RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_usr \
// RUN: -DTOOLCHAIN=%S/Inputs/basic_darwin_toolchain \
----------------
================
Comment at: clang/test/Driver/darwin-header-search-libcxx.cpp:119
// RUN: -nostdinc++ \
-// RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_usr \
+// RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_usr_cxx_v1 \
// RUN: -DTOOLCHAIN=%S/Inputs/basic_darwin_toolchain \
----------------
fahadnayyar wrote:
> ldionne wrote:
> > Is this change really needed anymore? Why?
> This is unrelated small bug in darwin-header-search-libcxx.cpp. I thought maybe we fix that small issue also in this patch. What you think?
Ah, I see. I think I understand the bug. Yeah I think it makes sense to fix it here but I added a few more fixes in comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148266/new/
https://reviews.llvm.org/D148266
More information about the cfe-commits
mailing list