[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 1 10:11:20 PDT 2023


rjmccall added a comment.

> I would like to clarify the second point to make sure that I'm incorporating that suggestion - the checks on lines 25, 26 & 27 are for actual calls - since now the signature matches the VTT type there's no arg setup prior to the call, it's a direct passing of the global. Were you thinking about something else here / am I missing somethign obvious?

Oh, sorry, somehow I glazed over those three lines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150746/new/

https://reviews.llvm.org/D150746



More information about the cfe-commits mailing list