[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 1 09:09:38 PDT 2023


nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.

Thanks for the patch!



================
Comment at: clang/test/Preprocessor/undef-x86.c:2
+// RUN: %clang_cc1 -triple=i386-none-none -fsyntax-only -verify %s
+// RUN: %clang_cc1 -triple=i686-none-none -fsyntax-only -verify %s
+// RUN: %clang_cc1 -triple=x86_64-none-none -fsyntax-only -verify %s
----------------
I don't think i686 adds anything beyond i386, at least for this test they are both `-m32`; consider removing this run line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151741/new/

https://reviews.llvm.org/D151741



More information about the cfe-commits mailing list