[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

[Takuya Shimizu via Phabricator via cfe-commits]

hazohelet marked 5 inline comments as done.
hazohelet added inline comments.


================
Comment at: clang/lib/AST/ExprConstant.cpp:1931
+      else
+          Out << ".";
+    } else if (const auto *OCE =
----------------
tbaeder wrote:
> Did you `clang-format` these changes? The two if/else body here seems indented 4 spaces instead  of 2.
Yes, I did run `git clang-format` before uploading. `clang-format` forces 4 spaces here even when I write 2 spaces.
Precommit CI's `clang-format` also seems to say nothing about the indentation here.
(Link: https://buildkite.com/llvm-project/premerge-checks/builds/155642#018875b6-df57-4c32-8f54-203e79d4a428)
So I think this might be an internal bug of `clang-format`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151720/new/

https://reviews.llvm.org/D151720