[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseLabels

[Galen Elias via Phabricator via cfe-commits]

galenelias added inline comments.


================
Comment at: clang/docs/ClangFormatStyleOptions.rst:790
+
+**AlignConsecutiveShortCaseLabels** (``AlignConsecutiveStyle``) :versionbadge:`clang-format 17` :ref:`¶ <AlignConsecutiveShortCaseLabels>`
+  Style of aligning consecutive short case labels.
----------------
MyDeveloperDay wrote:
> Did you generate this by hand or run the dump_format_style.py function? Format.h and the rst look out of sync
This was generated from dump_format_style.py.  What looks out of sync?  My guess is the confusing thing is all the styles which use `AlignConsecutiveStyle` get the same documentation pasted for them which specifically references `AlignConsecutiveMacros` and makes it look like it's for the wrong option.


================
Comment at: clang/unittests/Format/FormatTest.cpp:19255
+               Alignment);
+}
+
----------------
HazardyKnusperkeks wrote:
> Add a test with `AcrossEmptyLines` and `AcrossComments`.
There is a test for both `AcrossEmptyLines` and `AcrossComments`.  Maybe I'm not understanding your comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151761/new/

https://reviews.llvm.org/D151761