[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

[Sunil K via Phabricator via cfe-commits]

koops added a comment.

Can someone please let me know the following changes that I did in my latest patch?

1. clang/test/OpenMP/generic_loop_ast_print.cpp is failing because of the mapped directives. It is because of –ast-print & -ast-dump. This is because when the Sema comes across "omp loop bind( )" then it is mapped other constructs "omp simd", "omp for" or "omp distribute" . If the user of the compiler uses -ast-print then it is possible to be confused on seeing the new constructs.

I have not done the changes for -ast-dump since, it tends to be used mainly by the developer of clang. Can someone please let me know if I am correct? Can I correct the generic_loop_ast_print.cpp for the -ast-dump usage to reflect the mapped constructs instead of "omp loop"?

2. I have also written a testcase for "enclosed in different regions" : loop_bind_enclosed.cpp. I want to know if this correct and sufficient? Is there anything extra that I need to write or should it be done differently?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144634/new/

https://reviews.llvm.org/D144634