[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 31 17:12:27 PDT 2023


phosek marked 2 inline comments as done.
phosek added inline comments.


================
Comment at: bolt/test/CMakeLists.txt:40
   llvm-bolt
-  llvm-boltdiff
   llvm-bolt-heatmap
----------------
Amir wrote:
> We have a number of dependencies on llvm-boltdiff and perf2bolt, e.g. in internal and upstream binary tests: https://github.com/rafaelauler/bolt-tests/blob/main/CMakeLists.txt#L22. Can we keep these targets somehow?
These symlinks are now always generated, see the `ALWAYS_GENERATED` option in `add_bolt_tool_symlink` so there's no need to specify those as targets here separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151595/new/

https://reviews.llvm.org/D151595



More information about the cfe-commits mailing list