[PATCH] D151839: [LinkerWrapper] Fix static library symbol resolution

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 31 16:08:20 PDT 2023


tra added a comment.

LGTM in general.



================
Comment at: clang/test/Driver/linker-wrapper-libs.c:27
 //
 // Check that we extract a static library defining an undefined symbol.
 //
----------------
How does this test test the functionality of the undefined symbol? E.g. how does it fail now, before the patch?

Is there an explicit check we could to do to make sure things work as intended as opposed to "there's no obvious error" which may also mean "we forgot to process *undefined.bc".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151839/new/

https://reviews.llvm.org/D151839



More information about the cfe-commits mailing list