[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 31 13:30:20 PDT 2023


nickdesaulniers added inline comments.


================
Comment at: clang/test/Preprocessor/init-x86.c:1728-1741
+// RUN: %clang_cc1 -triple=i386-none-none -fsyntax-only -verify -DUNDEF %s
+// RUN: %clang_cc1 -triple=i686-none-none -fsyntax-only -verify -DUNDEF %s
+// RUN: %clang_cc1 -triple=x86_64-none-none -fsyntax-only -verify -DUNDEF %s
+#ifdef UNDEF
+// Check that we can undefine triple-specific defines without warning
+// expected-no-diagnostics
+#undef __i386
----------------
Hmm...I guess if this is going to require adding run lines, then let's move these to a new test file in the same dir. Maybe `undef-x86.c` or whatever? Sorry for back and forth.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151741/new/

https://reviews.llvm.org/D151741



More information about the cfe-commits mailing list