[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 31 10:47:28 PDT 2023


jansvoboda11 added inline comments.


================
Comment at: clang/lib/Serialization/ASTReader.cpp:4413
+        // first/next use via ASTReader::updateOutOfDateIdentifier().
+        II = &PP.getIdentifierTable().get(Key);
+      }
----------------
benlangmuir wrote:
> Why did this change from `getOwn` to `get`?
That's a fluke on my part, this should've remained `getOwn()`. These don't differ very much for C++ modules, but `getOwn()` is the intended functionality here for sure. I'll fix that in next revision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151277/new/

https://reviews.llvm.org/D151277



More information about the cfe-commits mailing list