[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

[Shoaib Meenai via Phabricator via cfe-commits]

smeenai added a comment.

Makes sense, though @Amir should also take a look.



================
Comment at: bolt/CMakeLists.txt:122
+
+add_custom_target(bolt DEPENDS ${BOLT_DEPENDS})
+set_target_properties(bolt PROPERTIES FOLDER "BOLT")
----------------
Where is BOLT_DEPENDS being set now?

The [CMake docs](https://cmake.org/cmake/help/latest/command/add_custom_target.html) say DEPENDS should only be used for add_custom_command outputs in the same folder, and add_dependencies for everything else, so we want the latter here. I know this is just moving existing code, but we may as well fix that while we're here. I don't think it makes any difference for Ninja, but it might for other generators?


================
Comment at: bolt/tools/heatmap/CMakeLists.txt:8
 
-add_bolt_tool(llvm-bolt-heatmap
+add_bolt_executable(llvm-bolt-heatmap
   heatmap.cpp
----------------
Why this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151595/new/

https://reviews.llvm.org/D151595