[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

Caroline via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 31 06:54:07 PDT 2023


CarolineConcatto marked 2 inline comments as done.
CarolineConcatto added inline comments.


================
Comment at: clang/include/clang/Basic/arm_sve.td:56
 // P: boolean
+// Qa: svcount
 // U: unsigned
----------------
hassnaa-arm wrote:
> sdesmalen wrote:
> > The typespec modifier in this file can remain `Q` rather than `Qa`. Can you change it back?
> what if there is a new type that is target-specific ?
> At that case we will have to find a new character.
> But if we now use Qa, we can use Qb for the new type.
> Is that correct ?
This is now removed. I thought that should reflect what is in Builtins.def, but it does not.
Because Q is being defined in sve target we do not the 'a' in 'Qa'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150953/new/

https://reviews.llvm.org/D150953



More information about the cfe-commits mailing list