[PATCH] D151537: [NFC] Update cpu_specific test to use a newer CPU

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 31 06:34:04 PDT 2023


erichkeane added a comment.

In D151537#4382811 <https://reviews.llvm.org/D151537#4382811>, @LuoYuanke wrote:

> In D151537#4380763 <https://reviews.llvm.org/D151537#4380763>, @erichkeane wrote:
>
>> I don't really see the justification here?  Why do this change?  If the intent is to just test a newer architecture, we can add tests for that, not change existing ones.
>
> KNL is deprecated and it is better to remove KNL related code in clang/llvm.

IS it deprecated in Clang?  I see an RFC proposing it, but I don't see acceptance of that yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151537/new/

https://reviews.llvm.org/D151537



More information about the cfe-commits mailing list