[PATCH] D148700: [clang] Add support for “regular” keyword attributes

Wed May 31 05:42:59 PDT 2023

rsandifo-arm added inline comments.

================
Comment at: clang-tools-extra/pseudo/lib/grammar/CMakeLists.txt:5
-# Dependencies should be minimal to avoid long dep paths in the build graph.
-# It does use clangBasic headers (tok::TokenKind), but linking is not needed.
-# We have no transitive dependencies on tablegen files.
----------------
thakis wrote:
> Did whoever wrote this comment sign up its removal? Looks like it was @sammccall in https://github.com/llvm/llvm-project/commit/dc63ad8878de6d0b5dc1268691f48035e9234763
No, sorry, I should have checked.

The type referenced in the comment (`tok::TokenKind`) is the one that is now being partially generated by tablegen.  Given that, there didn't seem any way of avoiding the dependency.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148700/new/

https://reviews.llvm.org/D148700