[PATCH] D151429: print user provide value in tabstop diagnostic

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 30 21:45:35 PDT 2023


This revision was automatically updated to reflect the committed changes.
Closed by commit rGa5bf4860eaee: print user provide value in tabstop diagnostic (authored by csmoe, committed by jansvoboda11).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151429/new/

https://reviews.llvm.org/D151429

Files:
  clang/lib/Frontend/CompilerInvocation.cpp


Index: clang/lib/Frontend/CompilerInvocation.cpp
===================================================================
--- clang/lib/Frontend/CompilerInvocation.cpp
+++ clang/lib/Frontend/CompilerInvocation.cpp
@@ -2394,9 +2394,9 @@
     DiagMask = DiagnosticLevelMask::All;
   Opts.setVerifyIgnoreUnexpected(DiagMask);
   if (Opts.TabStop == 0 || Opts.TabStop > DiagnosticOptions::MaxTabStop) {
-    Opts.TabStop = DiagnosticOptions::DefaultTabStop;
     Diags->Report(diag::warn_ignoring_ftabstop_value)
         << Opts.TabStop << DiagnosticOptions::DefaultTabStop;
+    Opts.TabStop = DiagnosticOptions::DefaultTabStop;
   }
 
   addDiagnosticArgs(Args, OPT_W_Group, OPT_W_value_Group, Opts.Warnings);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151429.526895.patch
Type: text/x-patch
Size: 704 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230531/227738e0/attachment.bin>


More information about the cfe-commits mailing list