[PATCH] D150212: [clang][Sema] Improve diagnostics for auto return type
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 30 19:48:55 PDT 2023
yaxunl added inline comments.
================
Comment at: clang/test/SemaCXX/auto-type-from-cxx.cpp:31-43
+class Abstract{
+ public:
+ void fun();
+ virtual void vfun()=0;
+ void call(){getCaller<Abstract>()(*this);} // expected-note {{in instantiation of function template specialization 'TestDeductionFail::getCaller<TestDeductionFail::Abstract>' requested here}}
+};
+
----------------
rsmith wrote:
> The end of this test seems unnecessary. Is there something else you want this test to cover, or can it be simplified?
I thought it was necessary to cause clang to emit the diagnostic messages, but you are right that they are unnecessary. I will remove them when committing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150212/new/
https://reviews.llvm.org/D150212
More information about the cfe-commits
mailing list