[PATCH] D150689: [clang][DependencyScanner] Remove all warning flags when suppressing warnings

Tue May 30 18:08:08 PDT 2023

Bigcheese added inline comments.

================
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:50
+  // optimize.
+  if (!IsSystemModule)
+    return;
----------------
ributzka wrote:
> This removes also all warnings when building your own module, because of the `[system]` attribute. I would prefer this optimization to be limited to modules that are in the sysroot and therefore ignore the `[system]` attribute. 
This is not really simple to do. We don't track why a module is a system module, and it's not really correct to do a string based match on the path for if it's from a system directory.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150689/new/

https://reviews.llvm.org/D150689