[PATCH] D150318: [clang][deps] NFC: Pass around the whole scanning service

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 30 13:58:03 PDT 2023


jansvoboda11 added a comment.

Any other feedback?



================
Comment at: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:19
 #include "clang/Serialization/ASTReader.h"
+#include "clang/Tooling/DependencyScanning/DependencyScanningService.h"
 #include "llvm/ADT/DenseMap.h"
----------------
benlangmuir wrote:
> Forward declaration for the header file should be enough
Good point, I'll do that before committing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150318/new/

https://reviews.llvm.org/D150318



More information about the cfe-commits mailing list