[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

[Denis Nikitin via Phabricator via cfe-commits]

denik accepted this revision.
denik added a comment.
This revision is now accepted and ready to land.

As long as having `In file included from` on each error **without notes** from one include file is fine, I don't see any problem with this. LGTM.
But let's check what others think about it.

For example:

  // 1.h
  int f() {
    b1();
    b2();
    b3();
  }

  // 1.c
  #include "1.h"

will have

  In file included from 1.c:1:
  ./1.h:3:3: error: use of undeclared identifier 'b1'
    b1();
    ^
  In file included from 1.c:1:
  ./1.h:4:3: error: use of undeclared identifier 'b2'
    b2();
    ^
  In file included from 1.c:1:
  ./1.h:5:3: error: use of undeclared identifier 'b3'
    b3();
    ^


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151575/new/

https://reviews.llvm.org/D151575