[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:23127
+  /// OMPDeclareTargetDeclAttr, and has global storage in the DeclVector. Pop 
+  /// each Decl one at a time and use the inherited Visit functions to look for 
+  /// DeclRefExpr.
----------------
Fix the strange symbol in the comment


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:23129
+  /// DeclRefExpr.
+  void declTargetInitializer(Decl *TD) {
+    A = TD->getAttr<OMPDeclareTargetDeclAttr>();
----------------
Function names should be verb phrases (as they represent actions), and command-like function should be imperative. (https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146418/new/

https://reviews.llvm.org/D146418