[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h
Paul Robinson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 30 10:15:14 PDT 2023
probinson marked an inline comment as done.
probinson added inline comments.
================
Comment at: clang/lib/Headers/avx2intrin.h:412
+/// vectors of [16 x i16] and returns the lower 16 bits of each difference
+/// in an element of the [16 x i16] result (overflow is ignored).
+/// Differences from \a __a are returned in the lower 64 bits of each
----------------
pengfei wrote:
> underflow?
I don't often see "underflow" applied to integer operations. Technically, any signed add or subtract could either overflow or underflow, depending on the sign and magnitude of the operands. I think just saying "overflow" is clear enough?
================
Comment at: clang/lib/Headers/avx2intrin.h:448
+/// vectors of [8 x i32] and returns the lower 32 bits of each difference in
+/// an element of the [8 x i31] result (overflow is ignored). Differences
+/// from \a __a are returned in the lower 64 bits of each 128-bit half of
----------------
pengfei wrote:
> pengfei wrote:
> > typo or intended?
> underflow.
The `i31` is a typo, fixed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150114/new/
https://reviews.llvm.org/D150114
More information about the cfe-commits
mailing list