[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 30 10:00:44 PDT 2023


arsenm added a comment.

In D151349#4377792 <https://reviews.llvm.org/D151349#4377792>, @yaxunl wrote:

> using ISA version to determine whether image is supported

That’s backward. You can track the feature in clang separately and just not emit it. We do that for a few other features. You just stop the TargetParser parts


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151349/new/

https://reviews.llvm.org/D151349



More information about the cfe-commits mailing list