[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

[hassnaaHamdi via Phabricator via cfe-commits]

hassnaa-arm added inline comments.


================
Comment at: clang/include/clang/Basic/Builtins.def:42
 //  q -> Scalable vector, followed by the number of elements and the base type.
+//  Q -> AArch64 svcount_t builtin type.
 //  E -> ext_vector, followed by the number of elements and the base type.
----------------
sdesmalen wrote:
> hassnaa-arm wrote:
> > sdesmalen wrote:
> > > Can we make 'Q' something to mean 'target type' and then use a second letter to clarify which exact target type it is, e.g.
> > > 
> > >   // Q -> target builtin type, followed by a character to distinguish the builtin type
> > >   //   Qa -> AArch64 svcount_t builtin type.
> > > 
> > > That should make it more extensible for other target types in the future.
> > Is that suggestion because maybe other targets don't support svcount ?
> Correct, `svcount_t` is an AArch64 specific type.
Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150953/new/

https://reviews.llvm.org/D150953