[PATCH] D151590: [Driver] Add ClangFlags::TargetSpecific to simplify err_drv_unsupported_opt_for_target processing

Tue May 30 07:36:18 PDT 2023

MaskRay added a comment.

In D151590#4379087 <https://reviews.llvm.org/D151590#4379087>, @qiongsiwu1 wrote:

> Thanks for the patch!
>
> Recently we added the options `mxcoff-roptr` and `mno-xcoff-roptr` https://reviews.llvm.org/D144190 that fall into this the scope of this patch (e.g. https://github.com/llvm/llvm-project/blob/0508ac32cfcc1a9fc5a81d16de8d418dc5a0666b/clang/lib/Driver/ToolChains/Clang.cpp#LL5278C19-L5278C19), since they are only supported on AIX. Could you add the handling of options `mxcoff-roptr` and `mno-xcoff-roptr`?

Hi @qiongsiwu1, thanks for chiming in. I am aware of `-mxcoff-roptr`. This patch picks some example patterns, but does not attempt to be comprehensive (on the GNU side, these are many many `-m` options that are not covered. E.g. LoongArch has a `-mabi` hack, so I cannot make `-mabi` `TargetSpecific` yet)
I can fold the `-mxcoff-roptr` change into this patch since it's straightforward.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151590/new/

https://reviews.llvm.org/D151590