[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 30 07:24:53 PDT 2023


erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.

1 nit, feel free to do this as a part of the commit.



================
Comment at: clang/lib/Sema/ParsedAttr.cpp:208
+    // The appurtenance rules are applied strictly for all regular keyword
+    // atributes.
+    return false;
----------------
Humorously, I spent an absurd amount of time trying to figure out whether appurtenance was a word/the correct spelling, determined you had it right and closed the phab review box, just to see `atributes` :D  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148702/new/

https://reviews.llvm.org/D148702



More information about the cfe-commits mailing list