[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

Tue May 30 07:08:23 PDT 2023

erichkeane added a comment.

I'm a little dense today perhaps, but I don't get the use case for this?  Can you ELI-EWG?  Is this an attribute we expect our users to use?  The name is horrifyingly long for users to use, but perhaps that is a good thing.

================
Comment at: clang/include/clang/Basic/AttrDocs.td:542
 If a statement is marked ``nomerge`` and contains call expressions, those call
-expressions inside the statement will not be merged during optimization. This 
+expressions inside the statement will not be merged during optimization. This
 attribute can be used to prevent the optimizer from obscuring the source
----------------
Unrelated changes. I realize your editor probably does this, please don't have it do it on this file.

================
Comment at: clang/include/clang/Basic/AttrDocs.td:3531
+defaulted equality comparison operator should be preferred over this attribute.
+On enums, the attribute guarantees that there are either no custom compatison
+operators defined, or any that defined are quivalent to the builtin comparison
----------------

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151625/new/

https://reviews.llvm.org/D151625