[PATCH] D151661: [clang] [test] Narrow down an MSVC specific behaviour to only not covever MinGW

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 29 13:19:19 PDT 2023


mstorsjo created this revision.
mstorsjo added reviewers: Endill, hans, aaron.ballman.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: clang.

This uses the same logic as in c2b256a990590dc8b69930259650cfeb085add03 <https://reviews.llvm.org/rGc2b256a990590dc8b69930259650cfeb085add03>;
we can't check defined(_MSC_VER) invoked as %clang_cc1, therefore
check for !defined(__MINGW32__) instead.

This fixes the same issue in a new testcase that was added after this
issue was fixed last time in c2b256a990590dc8b69930259650cfeb085add03 <https://reviews.llvm.org/rGc2b256a990590dc8b69930259650cfeb085add03>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D151661

Files:
  clang/test/CXX/drs/dr9xx.cpp


Index: clang/test/CXX/drs/dr9xx.cpp
===================================================================
--- clang/test/CXX/drs/dr9xx.cpp
+++ clang/test/CXX/drs/dr9xx.cpp
@@ -92,7 +92,7 @@
 
 namespace dr977 { // dr977: yes
 enum E { e = E() };
-#ifndef _WIN32
+#if !defined(_WIN32) || defined(__MINGW32__)
 // expected-error at -2 {{invalid use of incomplete type 'E'}}
 // expected-note at -3 {{definition of 'dr977::E' is not complete until the closing '}'}}
 #endif


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151661.526475.patch
Type: text/x-patch
Size: 463 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230529/1c6c89ff/attachment.bin>


More information about the cfe-commits mailing list