[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept
Piotr Zegar via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun May 28 06:22:54 PDT 2023
PiotrZSL accepted this revision.
PiotrZSL added a comment.
This revision is now accepted and ready to land.
On first glance, looks fine, but I didn't check it too deep.
Leave it open for 1-2 weeks. I will try to check it more deeply.
One thing that I see and do not like is duplication, maybe we could extract some "base check" from those 3 (in next step).
================
Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/noexcept-move-constructor.rst:5
+
+cppcoreguidelines-noexcept-move-constructor
+===========================================
----------------
maybe then it should be called cppcoreguidelines-noexcept-move-operations
================
Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:486
`cppcoreguidelines-non-private-member-variables-in-classes <cppcoreguidelines/non-private-member-variables-in-classes.html>`_, `misc-non-private-member-variables-in-classes <misc/non-private-member-variables-in-classes.html>`_,
- `cppcoreguidelines-use-default-member-init <cppcoreguidelines/use-default-member-init.html>`_, `modernize-use-default-member-init <modernize/use-default-member-init.html>`_,
+ `cppcoreguidelines-use-default-member-init <cppcoreguidelines/use-default-member-init.html>`_, `modernize-use-default-member-init <modernize/use-default-member-init.html>`_, "Yes"
`fuchsia-header-anon-namespaces <fuchsia/header-anon-namespaces.html>`_, `google-build-namespaces <google/build-namespaces.html>`_,
----------------
this is out of scope of this change, verify this
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148697/new/
https://reviews.llvm.org/D148697
More information about the cfe-commits
mailing list