[clang] f59795b - [NFC][CLANG] Fix nullptr dereference issue in CodeGenModule::GetConstantArrayFromStringLiteral()
via cfe-commits
cfe-commits at lists.llvm.org
Sat May 27 07:20:15 PDT 2023
Author: Manna, Soumi
Date: 2023-05-27T07:16:31-07:00
New Revision: f59795b2b703d5a782e4c29c0e786ee01942f16a
URL: https://github.com/llvm/llvm-project/commit/f59795b2b703d5a782e4c29c0e786ee01942f16a
DIFF: https://github.com/llvm/llvm-project/commit/f59795b2b703d5a782e4c29c0e786ee01942f16a.diff
LOG: [NFC][CLANG] Fix nullptr dereference issue in CodeGenModule::GetConstantArrayFromStringLiteral()
This patch adds an assert.
Reviewed By: erichkeane
Differential Revision: https://reviews.llvm.org/D151480
Added:
Modified:
clang/lib/CodeGen/CodeGenModule.cpp
Removed:
################################################################################
diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp
index d2a28b66cac9..49b670487749 100644
--- a/clang/lib/CodeGen/CodeGenModule.cpp
+++ b/clang/lib/CodeGen/CodeGenModule.cpp
@@ -5888,6 +5888,7 @@ CodeGenModule::GetConstantArrayFromStringLiteral(const StringLiteral *E) {
// Resize the string to the right size, which is indicated by its type.
const ConstantArrayType *CAT = Context.getAsConstantArrayType(E->getType());
+ assert(CAT && "String literal not of constant array type!");
Str.resize(CAT->getSize().getZExtValue());
return llvm::ConstantDataArray::getString(VMContext, Str, false);
}
More information about the cfe-commits
mailing list