[PATCH] D151572: [clang][ConstantEmitter] have tryEmitPrivate try ConstExprEmitter fast-path first

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added a comment.

In D151572#4376697 <https://reviews.llvm.org/D151572#4376697>, @efriedma wrote:

> Did you intentionally skip moving the ConstExprEmitter call in tryEmitPrivateForVarInit?  (VarDecl::evaluateValue calls the constant evaluator.)

Yes, I'll do that in a follow up patch as it results in quite a few test failures that I'm looking into now.  Triple check my messages on LLVM Discord. ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151572/new/

https://reviews.llvm.org/D151572