[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

Fri May 26 10:16:15 PDT 2023

codemzs added a comment.

Hi @rjmccall, @pengfei, and @zahiraam,

Thank you for your valuable review and acceptance of my patch. As I lack commit access, could I kindly request one of you to perform the commit on my behalf? Please use the following command: `git commit --amend --author="M. Zeeshan Siddiqui <mzs at microsoft.com>"`.

git commit message:

  [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling,
  and extend excess precision support

  Pursuant to discussions at
  https://discourse.llvm.org/t/rfc-c-23-p1467r9-extended-floating-point-types-and-standard-names/70033/22,
  this commit enhances the handling of the __bf16 type in Clang.
  - Firstly, it upgrades __bf16 from a storage-only type to an arithmetic
    type.
  - Secondly, it changes the mangling of __bf16 to DF16b on all
    architectures except ARM. This change has been made in
    accordance with the finalization of the mangling for the
    std::bfloat16_t type, as discussed at
    https://github.com/itanium-cxx-abi/cxx-abi/pull/147.
  - Finally, this commit extends the existing excess precision support to
    the __bf16 type. This applies to hardware architectures that do not
    natively support bfloat16 arithmetic.
  Appropriate tests have been added to verify the effects of these
  changes and ensure no regressions in other areas of the compiler.

  Reviewed By: rjmccall, pengfei, zahiraam

  Differential Revision: https://reviews.llvm.org/D150913

I would like to add that I have rebased this patch on LLVM main as of just now and also applied clang formatting to this patch. However, to maintain consistency and respect untouched lines, I opted to reverse certain clang-format changes, which might result in a clang format failure on Debian. Should you deem it necessary for me to apply clang formatting across all lines regardless, I am open to revising the format accordingly.

Your assistance is greatly appreciated.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150913/new/

https://reviews.llvm.org/D150913