[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

Thu May 25 19:48:02 PDT 2023

MaskRay added a comment.

In D150930#4356732 <https://reviews.llvm.org/D150930#4356732>, @jhuber6 wrote:

> In D150930#4355240 <https://reviews.llvm.org/D150930#4355240>, @MaskRay wrote:
>
>> Note: for options controlling individual optimization behaviors, there is a large probability that they may not make sense for Clang since the two compilers' internals are so different. 
>> Users and projects should learn to not add GCC optimization options for Clang uses.
>
> If this is the case, can we at least add a CMake option to disable LLVM from enabling this option against the user's will? As it stands https://reviews.llvm.org/rG47f5c54f997a59bb2c65abe6b8b811f6e7553456 represents a significant regression in usability. As I understand, the previous patch only had an issue with LTO builds, so it should be perfectly reasonable for users to at least disable this at the LLVM level if they do not with the LLVM build to insert an incompatible flag into their compilation database.

I am fine with the CMake work if someone wants to do it..

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150930/new/

https://reviews.llvm.org/D150930